[various] Lamp handlers expose min/max Color Temperature in state description #17641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndrewFG <[email protected]>
andrewfg
added
enhancement
andrewfg
requested review from
stefan-hoehn,
wborn and
cweitkamp
as code owners
Signed-off-by: AndrewFG <[email protected]>
Signed-off-by: AndrewFG <[email protected]>
lolodomo
reviewed
Oct 27, 2024
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
|
As discussed in the hue PR, there is a better option for the provider. |
Signed-off-by: AndrewFG <[email protected]>
andrewfg
changed the title
12 tasks
|
@andrewfg : what kind of tests exactly are you waiting for? |
Ideally I would like 1) to wait for your CT widget and then 2) ask users to test the min/max correct range. |
wborn
reviewed
Oct 29, 2024
...fx/src/main/java/org/openhab/binding/lifx/internal/handler/LifxStateDescriptionProvider.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/binding/nanoleaf/internal/handler/NanoLeafStateDescriptionProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AndrewFG <[email protected]>
andrewfg
changed the title
Signed-off-by: AndrewFG <[email protected]>
Signed-off-by: AndrewFG <[email protected]>
Signed-off-by: AndrewFG <[email protected]>
@lolodomo I spent some hours trying to write proper Junit tests with mocks etc. but in the end it would require modifying the bindings too substantially and risks to break more than it fixes. So instead, I have done some local actual and thought experiments on the code. And as a result I made some minor improvements. And I am now convinced that it is ready to merge. |
andrewfg
removed
the
additional testing preferred
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
…cription (openhab#17641) * Lamp handlers expose min/max Colour Temperature in state description * add color temperature validit and range checks Signed-off-by: AndrewFG <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
…cription (openhab#17641) * Lamp handlers expose min/max Colour Temperature in state description * add color temperature validit and range checks Signed-off-by: AndrewFG <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lamp handlers expose min/max Color Temperature in state description
Resolves #17638
Signed-off-by: AndrewFG [email protected]